( )⚙ D3868 manifest: make cachesize a private attribute

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3868

manifest: make cachesize a private attribute
ClosedPublic

Authored by indygreg on Jun 30 2018, 9:35 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG561a450c7b64: manifest: make cachesize a private attribute
Summary

AFAICT this isn't accessed outside the class. It is a private
attribute and its naming should reflect that.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Jun 30 2018, 9:35 PM
pulkit accepted this revision.Jul 1 2018, 1:52 PM
Closed by commit rHG561a450c7b64: manifest: make cachesize a private attribute (authored by indygreg). · Explain WhyJul 1 2018, 2:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/manifest.py (4 lines)

Diff 9382

mercurial/manifest.py

self._revlog = repo._constructmanifest() self._revlog = repo._constructmanifest()
self._narrowmatch = repo.narrowmatch() self._narrowmatch = repo.narrowmatch()
# A cache of the manifestctx or treemanifestctx for each directory # A cache of the manifestctx or treemanifestctx for each directory
self._dirmancache = {} self._dirmancache = {}
self._dirmancache[''] = util.lrucachedict(cachesize) self._dirmancache[''] = util.lrucachedict(cachesize)
self.cachesize = cachesize self._cachesize = cachesize
def __getitem__(self, node): def __getitem__(self, node):
"""Retrieves the manifest instance for the given node. Throws a """Retrieves the manifest instance for the given node. Throws a
LookupError if not found. LookupError if not found.
""" """
return self.get('', node) return self.get('', node)
def get(self, dir, node, verify=True): def get(self, dir, node, verify=True):
if self._treeinmem: if self._treeinmem:
m = treemanifestctx(self, '', node) m = treemanifestctx(self, '', node)
else: else:
m = manifestctx(self, node) m = manifestctx(self, node)
if node != revlog.nullid: if node != revlog.nullid:
mancache = self._dirmancache.get(dir) mancache = self._dirmancache.get(dir)
if not mancache: if not mancache:
mancache = util.lrucachedict(self.cachesize) mancache = util.lrucachedict(self._cachesize)
self._dirmancache[dir] = mancache self._dirmancache[dir] = mancache
mancache[node] = m mancache[node] = m
return m return m
def clearcaches(self): def clearcaches(self):
self._dirmancache.clear() self._dirmancache.clear()
self._revlog.clearcaches() self._revlog.clearcaches()