This is an archive of the discontinued Mercurial Phabricator instance.

rebase: improve output of --confirm option
AbandonedPublic

Authored by khanchi97 on Jul 1 2018, 5:52 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Before this patch --cofirm option was throwing the same rebasing
information two times, one before confirmation and one after. Also
added tests to reflect the same behavior.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

khanchi97 created this revision.Jul 1 2018, 5:52 AM
khanchi97 edited the summary of this revision. (Show Details)Jul 9 2018, 11:43 PM
khanchi97 updated this revision to Diff 9487.
khanchi97 updated this revision to Diff 9503.Jul 10 2018, 10:45 AM

This doesn't apply cleanly, could you rebase it?

hgext/rebase.py
975

I feel like the functions that accept supprbinfo should grow a docstring or comment that explains what supprbinfo does.

(I sort of figured it out, but it took a while.)

This doesn't apply cleanly, could you rebase it?

@durin42 I have made a change in --confirm option https://phab.mercurial-scm.org/D3944 if this functionality (don't prompt if hit a conflict) is acceptable then we don't need this patch (i.e suppressing rebase info). Thanks!

hgext/rebase.py
975

yeah, next time I will take care of this.

khanchi97 abandoned this revision.Aug 3 2018, 4:38 PM