This is an archive of the discontinued Mercurial Phabricator instance.

Differential D387

test: do not ignore test-check sanity check
ClosedPublic

Authored by quark on Aug 14 2017, 4:47 PM.
Tags
None
Subscribers
None

Details

Reviewers
simonfar
Group Reviewers
Restricted Project
Commits
rFBHGX765372cd7cf0: test: do not ignore test-check sanity check
Summary

Previously, if the system hg does not work, helper-testrepo.sh will skip
the test (usually test-check-*.t). This patch makes it stricter so a
non-functional system hg will be an error so it's less likely to be ignored.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

quark created this revision.Aug 14 2017, 4:47 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2017, 4:47 PM
simonfar accepted this revision.Aug 15 2017, 10:24 AM
This revision is now accepted and ready to land.Aug 15 2017, 10:24 AM
Closed by commit rFBHGX765372cd7cf0: test: do not ignore test-check sanity check (authored by quark). · Explain WhyAug 16 2017, 11:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/helper-testrepo.sh (8 lines)

Diff 879

tests/helper-testrepo.sh

cat >> "$HGRCPATH" <<EOF cat >> "$HGRCPATH" <<EOF
[extensions] [extensions]
lz4revlog= lz4revlog=
EOF EOF
fi fi
# sanity check whether hg actually works or not # sanity check whether hg actually works or not
if ! hg log -r tip -T '{author}' >/dev/null 2>"$TESTTMP/hg-err-check"; then if ! hg log -r tip -T '{author}' >/dev/null 2>"$TESTTMP/hg-err-check"; then
echo 'skipped: missing working hg' echo 'hg does not work'
exit 80 exit 1
fi fi
# hg might work but print "failed to ..." - treat that as an error # hg might work but print "failed to ..." - treat that as an error
if [ -s "$TESTTMP/hg-err-check" ]; then if [ -s "$TESTTMP/hg-err-check" ]; then
echo 'skipped: missing working hg' echo 'hg outputs to stderr: ' `cat "$TESTTMP/hg-err-check"`
exit 80 exit 1
fi fi