This is an archive of the discontinued Mercurial Phabricator instance.

manifest: define and implement rev() on manifestlog
ClosedPublic

Authored by indygreg on Jul 4 2018, 3:16 PM.

Details

Summary

Various code is accessing repo.manifestlog._revlog - a private
attribute. This bypasses our interface and makes it difficult to
implement non-revlog manifest storage.

This commit adds a rev() method to the manifestlog interface and
class and teaches callers to use it.

Ideally this method wouldn't exist, as very few consumers should
need to resolve the revision number of a manifest. Again, the
primary goal of interface work is to establish and use interfaces
first and to improve them later.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jul 4 2018, 3:16 PM
This revision was automatically updated to reflect the committed changes.