This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3884

tests: use interfaceutil in simplestorerepo
ClosedPublic

Authored by indygreg on Jul 4 2018, 3:16 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG404eab7ff33f: tests: use interfaceutil in simplestorerepo
Summary

Without it, we crash at module import time.

This has likely been busted since 856f381ad74b.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Jul 4 2018, 3:16 PM
pulkit accepted this revision.Jul 4 2018, 3:30 PM
Closed by commit rHG404eab7ff33f: tests: use interfaceutil in simplestorerepo (authored by indygreg). · Explain WhyJul 4 2018, 3:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/simplestorerepo.py (8 lines)

Diff 9437

tests/simplestorerepo.py

bin, bin,
hex, hex,
nullid, nullid,
nullrev, nullrev,
) )
from mercurial.thirdparty import ( from mercurial.thirdparty import (
cbor, cbor,
) )
from mercurial.thirdparty.zope import (
interface as zi,
)
from mercurial import ( from mercurial import (
ancestor, ancestor,
bundlerepo, bundlerepo,
error, error,
extensions, extensions,
localrepo, localrepo,
mdiff, mdiff,
pycompat, pycompat,
repository, repository,
revlog, revlog,
store, store,
verify, verify,
) )
from mercurial.utils import (
interfaceutil,
)
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
# be specifying the version(s) of Mercurial they are tested with, or # be specifying the version(s) of Mercurial they are tested with, or
# leave the attribute unspecified. # leave the attribute unspecified.
testedwith = 'ships-with-hg-core' testedwith = 'ships-with-hg-core'
REQUIREMENT = 'testonly-simplestore' REQUIREMENT = 'testonly-simplestore'
def validatenode(node): def validatenode(node):
if isinstance(node, int): if isinstance(node, int):
raise ValueError('expected node; got int') raise ValueError('expected node; got int')
if len(node) != 20: if len(node) != 20:
raise ValueError('expected 20 byte node') raise ValueError('expected 20 byte node')
def validaterev(rev): def validaterev(rev):
if not isinstance(rev, int): if not isinstance(rev, int):
raise ValueError('expected int') raise ValueError('expected int')
@zi.implementer(repository.ifilestorage) @interfaceutil.implementer(repository.ifilestorage)
class filestorage(object): class filestorage(object):
"""Implements storage for a tracked path. """Implements storage for a tracked path.
Data is stored in the VFS in a directory corresponding to the tracked Data is stored in the VFS in a directory corresponding to the tracked
path. path.
Index data is stored in an ``index`` file using CBOR. Index data is stored in an ``index`` file using CBOR.