( )⚙ D3886 strip: improve help text for --no-backup option

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3886

strip: improve help text for --no-backup option
ClosedPublic

Authored by khanchi97 on Jul 5 2018, 1:38 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGf442c9494ec7: strip: improve help text for --no-backup option
Summary

Help text is modified to clearly define the meaning of
--no-backup option.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

khanchi97 created this revision.Jul 5 2018, 1:38 AM
yuja added a subscriber: yuja.Jul 5 2018, 9:07 AM
  • --no-backup no backups

+ --no-backup do not save backup copies of files

"copies of files" sounds like working copy files. I think it should include
the word "bundle", e.g. "do not save backup bundle".

khanchi97 updated this revision to Diff 9460.Jul 5 2018, 3:11 PM
Closed by commit rHGf442c9494ec7: strip: improve help text for --no-backup option (authored by khanchi97). · Explain WhyJul 6 2018, 9:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/strip.py (5 lines)
Mtests/test-strip.t (2 lines)

Diff 9440

hgext/strip.py

@command("strip", @command("strip",
[ [
('r', 'rev', [], _('strip specified revision (optional, ' ('r', 'rev', [], _('strip specified revision (optional, '
'can specify revisions without this ' 'can specify revisions without this '
'option)'), _('REV')), 'option)'), _('REV')),
('f', 'force', None, _('force removal of changesets, discard ' ('f', 'force', None, _('force removal of changesets, discard '
'uncommitted changes (no backup)')), 'uncommitted changes (no backup)')),
('', 'no-backup', None, _('no backups')), ('', 'no-backup', None, _('do not save backup copies of files')),
('', 'nobackup', None, _('no backups (DEPRECATED)')), ('', 'nobackup', None, _('do not save backup copies of files '
'(DEPRECATED)')),
('n', '', None, _('ignored (DEPRECATED)')), ('n', '', None, _('ignored (DEPRECATED)')),
('k', 'keep', None, _("do not modify working directory during " ('k', 'keep', None, _("do not modify working directory during "
"strip")), "strip")),
('B', 'bookmark', [], _("remove revs only reachable from given" ('B', 'bookmark', [], _("remove revs only reachable from given"
" bookmark"))], " bookmark"))],
_('hg strip [-k] [-f] [-B bookmark] [-r] REV...')) _('hg strip [-k] [-f] [-B bookmark] [-r] REV...'))
def stripcmd(ui, repo, *revs, **opts): def stripcmd(ui, repo, *revs, **opts):
"""strip changesets and all their descendants from the repository """strip changesets and all their descendants from the repository

tests/test-strip.t

(use 'hg help -e strip' to show help for the strip extension) (use 'hg help -e strip' to show help for the strip extension)
options ([+] can be repeated): options ([+] can be repeated):
-r --rev REV [+] strip specified revision (optional, can specify -r --rev REV [+] strip specified revision (optional, can specify
revisions without this option) revisions without this option)
-f --force force removal of changesets, discard uncommitted -f --force force removal of changesets, discard uncommitted
changes (no backup) changes (no backup)
--no-backup no backups --no-backup do not save backup copies of files
-k --keep do not modify working directory during strip -k --keep do not modify working directory during strip
-B --bookmark VALUE [+] remove revs only reachable from given bookmark -B --bookmark VALUE [+] remove revs only reachable from given bookmark
--mq operate on patch repository --mq operate on patch repository
(use 'hg strip -h' to show more help) (use 'hg strip -h' to show more help)
[255] [255]
$ cd .. $ cd ..