This is an archive of the discontinued Mercurial Phabricator instance.

patchbomb: python 3 really wants those email addresses in unicode
ClosedPublic

Authored by durin42 on Jul 16 2018, 7:16 PM.

Details

Summary

At this point, test-patchbomb-tls.t almost passes on Python 3, but I'm
not really sure what the issue is: we just get a `abort: Connection
unexpectedly closed` that doesn't make sense to me.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Jul 16 2018, 7:16 PM
yuja added a subscriber: yuja.Jul 17 2018, 9:25 AM
  • sendmail(sender_addr, to + bcc + cc, fp.getvalue())

+ alldests = to + bcc + cc
+ alldests = [pycompat.strurl(d) for d in alldests]
+ sendmail(sender_addr, alldests, fp.getvalue())

encoding.strfromlocal() to avoid unicode exception.

durin42 updated this revision to Diff 10193.Aug 9 2018, 4:43 PM
This revision was automatically updated to reflect the committed changes.