( )⚙ D3997 fix: use ctx1.status(ctx2) instead of repo.status(ctx1, ctx2)

This is an archive of the discontinued Mercurial Phabricator instance.

fix: use ctx1.status(ctx2) instead of repo.status(ctx1, ctx2)
ClosedPublic

Authored by martinvonz on Aug 1 2018, 12:30 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Aug 1 2018, 12:30 PM
pulkit added a subscriber: pulkit.Aug 1 2018, 12:43 PM

I am curious why we are doing this? Is the end plan to deprecate repo.status()?

In D3997#62169, @pulkit wrote:

I am curious why we are doing this? Is the end plan to deprecate repo.status()?

I wasn't, this is just a little bit shorter, and it avoid looking up the ctx1 that we already have (repo[ctx] has fast-path that return ctx, so it's not expensive, just a little ugly IMO.

This revision was automatically updated to reflect the committed changes.