( )⚙ D3997 fix: use ctx1.status(ctx2) instead of repo.status(ctx1, ctx2)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3997

fix: use ctx1.status(ctx2) instead of repo.status(ctx1, ctx2)
ClosedPublic

Authored by martinvonz on Aug 1 2018, 12:30 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG260c17eaf3f7: fix: use ctx1.status(ctx2) instead of repo.status(ctx1, ctx2)
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Aug 1 2018, 12:30 PM
pulkit added a subscriber: pulkit.Aug 1 2018, 12:43 PM

I am curious why we are doing this? Is the end plan to deprecate repo.status()?

martinvonz added a comment.Aug 1 2018, 12:46 PM
In D3997#62169, @pulkit wrote:

I am curious why we are doing this? Is the end plan to deprecate repo.status()?

I wasn't, this is just a little bit shorter, and it avoid looking up the ctx1 that we already have (repo[ctx] has fast-path that return ctx, so it's not expensive, just a little ugly IMO.

Closed by commit rHG260c17eaf3f7: fix: use ctx1.status(ctx2) instead of repo.status(ctx1, ctx2) (authored by martinvonz). · Explain WhyAug 1 2018, 1:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fix.py (4 lines)

Diff 9688

hgext/fix.py

"""Returns the set of files that should be fixed in a context """Returns the set of files that should be fixed in a context
The result depends on the base contexts; we include any file that has The result depends on the base contexts; we include any file that has
changed relative to any of the base contexts. Base contexts should be changed relative to any of the base contexts. Base contexts should be
ancestors of the context being fixed. ancestors of the context being fixed.
""" """
files = set() files = set()
for basectx in basectxs: for basectx in basectxs:
stat = repo.status( stat = basectx.status(fixctx, match=match, listclean=bool(pats),
basectx, fixctx, match=match, clean=bool(pats), unknown=bool(pats)) listunknown=bool(pats))
files.update( files.update(
set(itertools.chain(stat.added, stat.modified, stat.clean, set(itertools.chain(stat.added, stat.modified, stat.clean,
stat.unknown))) stat.unknown)))
return files return files
def lineranges(opts, path, basectxs, fixctx, content2): def lineranges(opts, path, basectxs, fixctx, content2):
"""Returns the set of line ranges that should be fixed in a file """Returns the set of line ranges that should be fixed in a file