( )⚙ D4031 pycompat: add xrange alias for Python 2

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4031

pycompat: add xrange alias for Python 2
ClosedPublic

Authored by indygreg on Aug 1 2018, 4:10 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG7eba8f83129b: pycompat: add xrange alias for Python 2
Summary

We assign xrange on Python 3 but not Python 2. Adding the missing
symbol on Python 2 allows us to use pycompat.xrange to get a
generator range function.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 1 2018, 4:10 PM
durin42 accepted this revision.Aug 1 2018, 4:18 PM
This revision is now accepted and ready to land.Aug 1 2018, 4:18 PM
Closed by commit rHG7eba8f83129b: pycompat: add xrange alias for Python 2 (authored by indygreg). · Explain WhyAug 1 2018, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/pycompat.py (1 line)

Diff 9737

mercurial/pycompat.py

Python 3 compatibility as shelx.split() don't accept bytes on Python 3. Python 3 compatibility as shelx.split() don't accept bytes on Python 3.
""" """
ret = shlex.split(s.decode('latin-1'), comments, posix) ret = shlex.split(s.decode('latin-1'), comments, posix)
return [a.encode('latin-1') for a in ret] return [a.encode('latin-1') for a in ret]
else: else:
import cStringIO import cStringIO
xrange = xrange
unicode = unicode unicode = unicode
bytechr = chr bytechr = chr
byterepr = repr byterepr = repr
bytestr = str bytestr = str
iterbytestr = iter iterbytestr = iter
maybebytestr = identity maybebytestr = identity
sysbytes = identity sysbytes = identity
sysstr = identity sysstr = identity