This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4098

narrow: drop checkambig=True when restoring backup
ClosedPublic

Authored by martinvonz on Aug 3 2018, 5:24 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG204e074c188e: narrow: drop checkambig=True when restoring backup
Summary

IIUC, checkambig is about updating timestamps of the file while
renaming. That's important for the dirstate, but we never check the
timestamp of the narrowspec file. We can therefore avoid checking
passing checkambig=True.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 3 2018, 5:24 PM
martinvonz updated this revision to Diff 9873.Aug 3 2018, 8:12 PM
Closed by commit rHG204e074c188e: narrow: drop checkambig=True when restoring backup (authored by martinvonz). · Explain WhyAug 5 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/narrowspec.py (2 lines)

Diff 9933

mercurial/narrowspec.py

return return
vfs = repo.vfs vfs = repo.vfs
vfs.tryunlink(backupname) vfs.tryunlink(backupname)
util.copyfile(vfs.join(FILENAME), vfs.join(backupname), hardlink=True) util.copyfile(vfs.join(FILENAME), vfs.join(backupname), hardlink=True)
def restorebackup(repo, backupname): def restorebackup(repo, backupname):
if repository.NARROW_REQUIREMENT not in repo.requirements: if repository.NARROW_REQUIREMENT not in repo.requirements:
return return
repo.vfs.rename(backupname, FILENAME, checkambig=True) repo.vfs.rename(backupname, FILENAME)
def clearbackup(repo, backupname): def clearbackup(repo, backupname):
if repository.NARROW_REQUIREMENT not in repo.requirements: if repository.NARROW_REQUIREMENT not in repo.requirements:
return return
repo.vfs.unlink(backupname) repo.vfs.unlink(backupname)
def restrictpatterns(req_includes, req_excludes, repo_includes, repo_excludes): def restrictpatterns(req_includes, req_excludes, repo_includes, repo_excludes):
r""" Restricts the patterns according to repo settings, r""" Restricts the patterns according to repo settings,