This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4104

index: return False for "len(index) in index"
ClosedPublic

Authored by martinvonz on Aug 5 2018, 2:33 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGaa33988ad8ab: index: return False for "len(index) in index"
Summary

Since we no longer accept index[len(index)], we should clearly make
"len(index) in index" return False. This should have been part of
a3dacabd476b (index: don't allow index[len(index)] to mean nullid,
2018-07-20)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (2 lines)

Diff 9928

mercurial/cext/revlog.c

} }
static int index_contains(indexObject *self, PyObject *value) static int index_contains(indexObject *self, PyObject *value)
{ {
char *node; char *node;
if (PyInt_Check(value)) { if (PyInt_Check(value)) {
long rev = PyInt_AS_LONG(value); long rev = PyInt_AS_LONG(value);
return rev >= -1 && rev < index_length(self) + 1; return rev >= -1 && rev < index_length(self);
} }
if (node_check(value, &node) == -1) if (node_check(value, &node) == -1)
return -1; return -1;
switch (index_find_node(self, node, 20)) { switch (index_find_node(self, node, 20)) {
case -3: case -3:
return -1; return -1;