This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4105

index: drop support for nullid at position len(index) in index_node
ClosedPublic

Authored by martinvonz on Aug 5 2018, 2:33 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4c0fd3f0a15d: index: drop support for nullid at position len(index) in index_node
Summary

I think no callers exist since at least a3dacabd476b (index: don't
allow index[len(index)] to mean nullid, 2018-07-20).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Aug 5 2018, 2:33 AM
Closed by commit rHG4c0fd3f0a15d: index: drop support for nullid at position len(index) in index_node (authored by martinvonz). · Explain WhyAug 5 2018, 9:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cext/revlog.c (4 lines)

Diff 9929

mercurial/cext/revlog.c

/* /*
* Return the 20-byte SHA of the node corresponding to the given rev. * Return the 20-byte SHA of the node corresponding to the given rev.
*/ */
static const char *index_node(indexObject *self, Py_ssize_t pos) static const char *index_node(indexObject *self, Py_ssize_t pos)
{ {
Py_ssize_t length = index_length(self) + 1; Py_ssize_t length = index_length(self) + 1;
const char *data; const char *data;
if (pos == length - 1 || pos == -1) if (pos == -1)
return nullid; return nullid;
if (pos >= length) if (pos >= length - 1)
return NULL; return NULL;
if (pos >= self->length - 1) { if (pos >= self->length - 1) {
PyObject *tuple, *str; PyObject *tuple, *str;
tuple = PyList_GET_ITEM(self->added, pos - self->length + 1); tuple = PyList_GET_ITEM(self->added, pos - self->length + 1);
str = PyTuple_GetItem(tuple, 7); str = PyTuple_GetItem(tuple, 7);
return str ? PyBytes_AS_STRING(str) : NULL; return str ? PyBytes_AS_STRING(str) : NULL;
} }