| martinvonz |
| hg-reviewers |
These were both brought up during the codereview of D4130.
| Lint Skipped |
| Unit Tests Skipped |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/match.py (1 line) | |||
| M | tests/test-match.py (2 lines) |
| Commit | Parents | Author | Summary | Date |
|---|---|---|---|---|
| Kyle Lippincott | Aug 8 2018, 8:03 PM |
| def visitchildrenset(self, dir): | def visitchildrenset(self, dir): | ||||
| if dir == self._path: | if dir == self._path: | ||||
| return self._matcher.visitchildrenset('.') | return self._matcher.visitchildrenset('.') | ||||
| if dir.startswith(self._pathprefix): | if dir.startswith(self._pathprefix): | ||||
| return self._matcher.visitchildrenset(dir[len(self._pathprefix):]) | return self._matcher.visitchildrenset(dir[len(self._pathprefix):]) | ||||
| if dir in self._pathdirs: | if dir in self._pathdirs: | ||||
| return 'this' | return 'this' | ||||
| return set() | |||||
| def isexact(self): | def isexact(self): | ||||
| return self._matcher.isexact() | return self._matcher.isexact() | ||||
| def prefix(self): | def prefix(self): | ||||
| return self._matcher.prefix() | return self._matcher.prefix() | ||||
| @encoding.strmethod | @encoding.strmethod | ||||
| self.assertFalse(m.visitdir('dir/subdir')) | self.assertFalse(m.visitdir('dir/subdir')) | ||||
| def testVisitchildrensetRootfilesin(self): | def testVisitchildrensetRootfilesin(self): | ||||
| m = matchmod.match('x', '', patterns=['rootfilesin:dir/subdir']) | m = matchmod.match('x', '', patterns=['rootfilesin:dir/subdir']) | ||||
| assert isinstance(m, matchmod.patternmatcher) | assert isinstance(m, matchmod.patternmatcher) | ||||
| self.assertEqual(m.visitchildrenset('.'), 'this') | self.assertEqual(m.visitchildrenset('.'), 'this') | ||||
| self.assertEqual(m.visitchildrenset('dir/subdir/x'), set()) | self.assertEqual(m.visitchildrenset('dir/subdir/x'), set()) | ||||
| self.assertEqual(m.visitchildrenset('folder'), set()) | self.assertEqual(m.visitchildrenset('folder'), set()) | ||||
| # FIXME: These should probably be {'subdir'} and 'this', respectively, | |||||
| # or at least 'this' and 'this'. | |||||
| self.assertEqual(m.visitchildrenset('dir'), set()) | self.assertEqual(m.visitchildrenset('dir'), set()) | ||||
| self.assertEqual(m.visitchildrenset('dir/subdir'), set()) | self.assertEqual(m.visitchildrenset('dir/subdir'), set()) | ||||
| def testVisitdirGlob(self): | def testVisitdirGlob(self): | ||||
| m = matchmod.match('x', '', patterns=['glob:dir/z*']) | m = matchmod.match('x', '', patterns=['glob:dir/z*']) | ||||
| assert isinstance(m, matchmod.patternmatcher) | assert isinstance(m, matchmod.patternmatcher) | ||||
| self.assertTrue(m.visitdir('.')) | self.assertTrue(m.visitdir('.')) | ||||
| self.assertTrue(m.visitdir('dir')) | self.assertTrue(m.visitdir('dir')) | ||||