This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4200

fastannotate: record some TODO items from indygreg's review
ClosedPublic

Authored by durin42 on Aug 9 2018, 3:13 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGca053fc7efc5: fastannotate: record some TODO items from indygreg's review
Summary

Some of these I'll address more or less right away, but some will take
a while for us to resolve.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Aug 9 2018, 3:13 PM
indygreg accepted this revision.Aug 9 2018, 11:36 PM
This revision is now accepted and ready to land.Aug 9 2018, 11:36 PM
Closed by commit rHGca053fc7efc5: fastannotate: record some TODO items from indygreg's review (authored by durin42). · Explain WhyAug 20 2018, 3:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/fastannotate/__init__.py (26 lines)

Diff 10473

hgext/fastannotate/__init__.py

unfilteredrepo = True unfilteredrepo = True
# sacrifice correctness in some corner cases for performance. it does not # sacrifice correctness in some corner cases for performance. it does not
# affect the correctness of the annotate cache being built. the option # affect the correctness of the annotate cache being built. the option
# is experimental and may disappear in the future (default: False) # is experimental and may disappear in the future (default: False)
perfhack = True perfhack = True
""" """
# TODO from import:
# * `branch` is probably the wrong term, throughout the code.
#
# * replace the fastannotate `modes` configuration with a collection
# of booleans.
#
# * Use the templater instead of bespoke formatting
#
# * rename the config knob for updating the local cache from a remote server
#
# * remove the remotefilelog-peer-sharing functionality
#
# * move various global-setup bits to extsetup() or reposetup()
#
# * assume repo.requirements will always exist
#
# * move `flock` based locking to a common area
#
# * revise wireprotocol for sharing annotate files
#
# * figure out a sensible default for `mainbranch` (with the caveat
# that we probably also want to figure out a better term than
# `branch`, see above)
#
# * format changes to the revmap file (maybe use length-encoding
# instead of null-terminated file paths at least?)
from __future__ import absolute_import from __future__ import absolute_import
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial import ( from mercurial import (
error as hgerror, error as hgerror,
localrepo, localrepo,
registrar, registrar,
util, util,