( )⚙ D4249 contrib: have check-code look at files in latin1 instead of ascii

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4249

contrib: have check-code look at files in latin1 instead of ascii
ClosedPublic

Authored by durin42 on Aug 10 2018, 2:21 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc52a8af4052a: contrib: have check-code look at files in latin1 instead of ascii
Summary

This way all files open. So far none of our patterns look like they'll care.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Aug 10 2018, 2:21 AM
pulkit accepted this revision.Aug 10 2018, 8:12 AM
Closed by commit rHGc52a8af4052a: contrib: have check-code look at files in latin1 instead of ascii (authored by durin42). · Explain WhyAug 10 2018, 8:25 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/check-code.py (2 lines)

Diff 10283

contrib/check-code.py

import optparse import optparse
import os import os
import re import re
import sys import sys
if sys.version_info[0] < 3: if sys.version_info[0] < 3:
opentext = open opentext = open
else: else:
def opentext(f): def opentext(f):
return open(f, encoding='ascii') return open(f, encoding='latin1')
try: try:
xrange xrange
except NameError: except NameError:
xrange = range xrange = range
try: try:
import re2 import re2
except ImportError: except ImportError:
re2 = None re2 = None