This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4250

tests: add missing b'' prefix in test-check-code.t
ClosedPublic

Authored by durin42 on Aug 10 2018, 2:21 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG850fe0b9c0c0: tests: add missing b'' prefix in test-check-code.t
Summary

It now passes on Python 3.

  1. skip-blame b prefix

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Aug 10 2018, 2:21 AM
pulkit accepted this revision.Aug 10 2018, 8:12 AM
Closed by commit rHG850fe0b9c0c0: tests: add missing b'' prefix in test-check-code.t (authored by durin42). · Explain WhyAug 10 2018, 8:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/python3-whitelist (1 line)
Mtests/test-check-code.t (2 lines)

Diff 10284

contrib/python3-whitelist

test-bundle2-pushback.t test-bundle2-pushback.t
test-bundle2-remote-changegroup.t test-bundle2-remote-changegroup.t
test-cappedreader.py test-cappedreader.py
test-casecollision.t test-casecollision.t
test-cat.t test-cat.t
test-cbor.py test-cbor.py
test-censor.t test-censor.t
test-changelog-exec.t test-changelog-exec.t
test-check-code.t
test-check-commit.t test-check-commit.t
test-check-execute.t test-check-execute.t
test-check-interfaces.py test-check-interfaces.py
test-check-module-imports.t test-check-module-imports.t
test-check-pyflakes.t test-check-pyflakes.t
test-check-pylint.t test-check-pylint.t
test-check-shbang.t test-check-shbang.t
test-children.t test-children.t

tests/test-check-code.t

Skipping tests/badserverext.py it has no-che?k-code (glob) Skipping tests/badserverext.py it has no-che?k-code (glob)
@commands in debugcommands.py should be in alphabetical order. @commands in debugcommands.py should be in alphabetical order.
>>> import re >>> import re
>>> commands = [] >>> commands = []
>>> with open('mercurial/debugcommands.py', 'rb') as fh: >>> with open('mercurial/debugcommands.py', 'rb') as fh:
... for line in fh: ... for line in fh:
... m = re.match("^@command\('([a-z]+)", line) ... m = re.match(b"^@command\('([a-z]+)", line)
... if m: ... if m:
... commands.append(m.group(1)) ... commands.append(m.group(1))
>>> scommands = list(sorted(commands)) >>> scommands = list(sorted(commands))
>>> for i, command in enumerate(scommands): >>> for i, command in enumerate(scommands):
... if command != commands[i]: ... if command != commands[i]:
... print('commands in debugcommands.py not sorted; first differing ' ... print('commands in debugcommands.py not sorted; first differing '
... 'command is %s; expected %s' % (commands[i], command)) ... 'command is %s; expected %s' % (commands[i], command))
... break ... break