This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4325

dagutil: remove unused classes
ClosedPublic

Authored by indygreg on Aug 17 2018, 5:31 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG4cf3f54cc8e7: dagutil: remove unused classes
Summary

We only directly use revlogdag in changegroup code. We don't need
all this abstraction. So remove various classes and levels
of inheritance.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 17 2018, 5:31 PM
Closed by commit rHG4cf3f54cc8e7: dagutil: remove unused classes (authored by indygreg). · Explain WhyAug 18 2018, 4:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/dagutil.py (49 lines)

Diff 10446

mercurial/dagutil.py

# dagutil.py - dag utilities for mercurial # dagutil.py - dag utilities for mercurial
# #
# Copyright 2010 Benoit Boissinot <bboissin@gmail.com> # Copyright 2010 Benoit Boissinot <bboissin@gmail.com>
# and Peter Arrenbrecht <peter@arrenbrecht.ch> # and Peter Arrenbrecht <peter@arrenbrecht.ch>
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
from __future__ import absolute_import from __future__ import absolute_import
from .node import nullrev from .node import nullrev
class basedag(object): class revlogdag(object):
'''generic interface for DAGs
terms:
"ix" (short for index) identifies a nodes internally,
"id" identifies one externally.
All params are ixs unless explicitly suffixed otherwise.
Pluralized params are lists or sets.
'''
def parents(self, ix):
'''list of parents ixs of ix'''
raise NotImplementedError
def headsetofconnecteds(self, ixs):
'''
subset of connected list of ixs so that no node has a descendant in it
By "connected list" we mean that if an ancestor and a descendant are in
the list, then so is at least one path connecting them.
'''
raise NotImplementedError
class genericdag(basedag):
'''generic implementations for DAGs'''
def headsetofconnecteds(self, ixs):
hds = set(ixs)
if not hds:
return hds
for n in ixs:
for p in self.parents(n):
hds.discard(p)
assert hds
return hds
class revlogbaseddag(basedag):
'''generic dag interface to a revlog'''
def __init__(self, revlog):
basedag.__init__(self)
self._revlog = revlog
class revlogdag(revlogbaseddag):
'''dag interface to a revlog''' '''dag interface to a revlog'''
def __init__(self, revlog): def __init__(self, revlog):
revlogbaseddag.__init__(self, revlog) self._revlog = revlog
def parents(self, ix): def parents(self, ix):
rlog = self._revlog rlog = self._revlog
idx = rlog.index idx = rlog.index
revdata = idx[ix] revdata = idx[ix]
prev = revdata[5] prev = revdata[5]
if prev != nullrev: if prev != nullrev:
prev2 = revdata[6] prev2 = revdata[6]