This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4330

dagutil: remove module
ClosedPublic

Authored by indygreg on Aug 17 2018, 5:31 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd39b1f7e5dcf: dagutil: remove module
Summary

The previous commit removed the last consumer of this module.

.. api:: dagutil module has been removed

Some functionality has been moved to the dagop module. Other
functionality can be accomplished via revsets.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Aug 17 2018, 5:31 PM
Closed by commit rHGd39b1f7e5dcf: dagutil: remove module (authored by indygreg). · Explain WhyAug 18 2018, 4:07 AM
This revision was automatically updated to reflect the committed changes.
lothiraldan added a subscriber: lothiraldan.Aug 18 2018, 5:32 AM

Could we keep the module around for a version with deprecated warnings? The removal of the module will likely impacts some extensions (evolve for example)

indygreg added a comment.Aug 19 2018, 6:47 PM
In D4330#66554, @lothiraldan wrote:

Could we keep the module around for a version with deprecated warnings? The removal of the module will likely impacts some extensions (evolve for example)

The module was hardly used before. And evolve has broken against new Mercurial versions before. Of all the 3rd party extensions I use, only evolve uses dagutil. So I have my doubts that we need to keep dagutil around to ease transitions.

Revision Contents
Changeset List

PathPackages
DMmercurial/dagutil.py (49 lines)

Diff 10451

mercurial/dagutil.py

  • This file was deleted.
# dagutil.py - dag utilities for mercurial
#
# Copyright 2010 Benoit Boissinot <bboissin@gmail.com>
# and Peter Arrenbrecht <peter@arrenbrecht.ch>
#
# This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version.
from __future__ import absolute_import
from .node import nullrev
from . import (
dagop,
)
class revlogdag(object):
'''dag interface to a revlog'''
def __init__(self, revlog):
self._revlog = revlog
def linearize(self, ixs):
'''linearize and topologically sort a list of revisions
The linearization process tries to create long runs of revs where
a child rev comes immediately after its first parent. This is done by
visiting the heads of the given revs in inverse topological order,
and for each visited rev, visiting its second parent, then its first
parent, then adding the rev itself to the output list.
'''
sorted = []
visit = list(dagop.headrevs(ixs, self._revlog.parentrevs))
visit.sort(reverse=True)
finished = set()
while visit:
cur = visit.pop()
if cur < 0:
cur = -cur - 1
if cur not in finished:
sorted.append(cur)
finished.add(cur)
else:
visit.append(-cur - 1)
visit += [p for p in self._revlog.parentrevs(cur)
if p != nullrev and p in ixs and p not in finished]
assert len(sorted) == len(ixs)
return sorted