This is an archive of the discontinued Mercurial Phabricator instance.

Differential D432

undo: allprecursors -> allpredecessors
ClosedPublic

Authored by ryanmce on Aug 17 2017, 2:00 PM.
Tags
None
Subscribers
None

Details

Reviewers
simonfar
Group Reviewers
Restricted Project
Commits
rFBHGX8f773aea3994: undo: allprecursors -> allpredecessors
Summary

Per upstream name changes. Eliminated develwarns.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Tests OK

Event Timeline

ryanmce created this revision.Aug 17 2017, 2:00 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2017, 2:00 PM
simonfar accepted this revision.Aug 17 2017, 3:20 PM
This revision is now accepted and ready to land.Aug 17 2017, 3:20 PM
Closed by commit rFBHGX8f773aea3994: undo: allprecursors -> allpredecessors (authored by ryanmce). · Explain WhyAug 18 2017, 6:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/undo.py (2 lines)

Diff 1034

hgext3rd/undo.py

use local to not hide revhides without corresponding revshows use local to not hide revhides without corresponding revshows
''' '''
hidectxs = repo.set(revhide) hidectxs = repo.set(revhide)
showctxs = repo.set(revshow) showctxs = repo.set(revshow)
for ctx in hidectxs: for ctx in hidectxs:
unfi = repo.unfiltered() unfi = repo.unfiltered()
related = [] related = []
related = set(obsutil.allprecursors(unfi.obsstore, [ctx.node()])) related = set(obsutil.allpredecessors(unfi.obsstore, [ctx.node()]))
related.update(obsutil.allsuccessors(unfi.obsstore, [ctx.node()])) related.update(obsutil.allsuccessors(unfi.obsstore, [ctx.node()]))
related.intersection_update(x.node() for x in showctxs) related.intersection_update(x.node() for x in showctxs)
destinations = [repo[x] for x in related] destinations = [repo[x] for x in related]
# two primary objectives: # two primary objectives:
# 1. correct divergence/nondivergence # 1. correct divergence/nondivergence
# 2. correct visibility of changesets for the user # 2. correct visibility of changesets for the user
# secondary objectives: # secondary objectives:
# 3. usefull ui message in hg sl: "Undone to" # 3. usefull ui message in hg sl: "Undone to"