( )⚙ D4331 nodes: expand/comment the magic nodes so they are more easily searchable

This is an archive of the discontinued Mercurial Phabricator instance.

nodes: expand/comment the magic nodes so they are more easily searchable
ClosedPublic

Authored by spectral on Aug 17 2018, 6:32 PM.

Details

Summary

We just encountered 000000000000modified, and it was quite annoying to search
for these, even though I knew they existed. For those that don't know that they
exist, this is essentially impossible to search for :)

(Technically we encountered it in its hex form,
3030303030303030303030306d6f646966696564, so I'm adding comments with those
forms in case that's helpful to people in the future).

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

spectral created this revision.Aug 17 2018, 6:32 PM
This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.
mercurial/node.py
32

Isn't it 30303030... in hex? I'd prefer to fix it by changing the actual value to be what the comment says, though.

spectral marked an inline comment as done.Aug 22 2018, 3:27 PM
spectral added inline comments.
mercurial/node.py
32

Indeed, looks like yuya already fixed this for me (by fixing the comment, not changing the id) in 1e7a462cb946, sorry about that!