This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	10545		Aug 24 2018, 1:36 AM	★	★
Diff 2	10833		Sep 7 2018, 4:07 PM	★	★
Diff 3	10871	rHG4df252c01f16025ddedf587c31f60aa98fdcffb0	Aug 23 2018, 3:33 AM	★	★

Commit	Parents	Author	Summary	Date
		Kyle Lippincott		Aug 23 2018, 3:33 AM

Status	Author	Revision
Closed	spectral	D4371 treemanifest: use visitchildrenset when doing a walk
Closed	spectral	D4370 treemanifest: use visitchildrenset when filtering a manifest to a matcher
Closed	spectral	D4369 treemanifest: avoid loading everything just to get their nodeid
Closed	spectral	D4368 treemanifest: avoid unnecessary copies/processing when using alwaysmatcher
Closed	spectral	D4367 treemanifest: attempt to avoid loading all lazily-loaded subdirs in _isempty
Closed	spectral	D4366 treemanifest: introduce lazy loading of subdirs
Closed	spectral	D4365 match: make exactmatcher.visitchildrenset return file children as well
Closed	spectral	D4364 match: document that visitchildrenset might return files

Diff 10833

	def __nonzero__(self):			def __nonzero__(self):
	# Faster than "__len() != 0" since it avoids loading sub-manifests			# Faster than "__len() != 0" since it avoids loading sub-manifests
	return not self._isempty()			return not self._isempty()

	__bool__ = __nonzero__			__bool__ = __nonzero__

	def _isempty(self):			def _isempty(self):
	self._load() # for consistency; already loaded by all callers			self._load() # for consistency; already loaded by all callers
				# See if we can skip loading everything.
				if self._files or (self._dirs and
				any(not m._isempty() for m in self._dirs.values())):
				return False
	self._loadalllazy()			self._loadalllazy()
	return (not self._files and (not self._dirs or			return (not self._dirs or
	all(m._isempty() for m in self._dirs.values())))			all(m._isempty() for m in self._dirs.values()))

	def __repr__(self):			def __repr__(self):
	return ('<treemanifest dir=%s, node=%s, loaded=%s, dirty=%s at 0x%x>' %			return ('<treemanifest dir=%s, node=%s, loaded=%s, dirty=%s at 0x%x>' %
	(self._dir, hex(self._node),			(self._dir, hex(self._node),
	bool(self._loadfunc is _noop),			bool(self._loadfunc is _noop),
	self._dirty, id(self)))			self._dirty, id(self)))

	def dir(self):			def dir(self):