This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	10547		Aug 24 2018, 1:36 AM	★	★
Diff 2	10835		Sep 7 2018, 4:07 PM	★	★
Diff 3	10873	rHG1d8d3699a6d1aae948069a371808d670f90466d7	Aug 23 2018, 3:41 AM	★	★

Commit	Parents	Author	Summary	Date
		Kyle Lippincott		Aug 23 2018, 3:41 AM

Status	Author	Revision
Closed	spectral	D4371 treemanifest: use visitchildrenset when doing a walk
Closed	spectral	D4370 treemanifest: use visitchildrenset when filtering a manifest to a matcher
Closed	spectral	D4369 treemanifest: avoid loading everything just to get their nodeid
Closed	spectral	D4368 treemanifest: avoid unnecessary copies/processing when using alwaysmatcher
Closed	spectral	D4367 treemanifest: attempt to avoid loading all lazily-loaded subdirs in _isempty
Closed	spectral	D4366 treemanifest: introduce lazy loading of subdirs
Closed	spectral	D4365 match: make exactmatcher.visitchildrenset return file children as well
Closed	spectral	D4364 match: document that visitchildrenset might return files

Diff 10835

	s._dirty = False			s._dirty = False
	self._loadfunc = _load_for_read			self._loadfunc = _load_for_read

	def writesubtrees(self, m1, m2, writesubtree):			def writesubtrees(self, m1, m2, writesubtree):
	self._load() # for consistency; should never have any effect here			self._load() # for consistency; should never have any effect here
	m1._load()			m1._load()
	m2._load()			m2._load()
	emptytree = treemanifest()			emptytree = treemanifest()
	# OPT: Do we really need to load everything? Presumably things in lazy			def getnode(m, d):
	# aren't dirty and don't need to be written.			ld = m._lazydirs.get(d)
	self._loadalllazy()			if ld:
	m1._loadalllazy()			return ld[1]
	m2._loadalllazy()			return m._dirs.get(d, emptytree)._node

	for d, subm in self._dirs.iteritems():			for d, subm in self._dirs.iteritems():
	subp1 = m1._dirs.get(d, emptytree)._node			subp1 = getnode(m1, d)
	subp2 = m2._dirs.get(d, emptytree)._node			subp2 = getnode(m2, d)
	if subp1 == nullid:			if subp1 == nullid:
	subp1, subp2 = subp2, subp1			subp1, subp2 = subp2, subp1
	writesubtree(subm, subp1, subp2)			writesubtree(subm, subp1, subp2)

	def walksubtrees(self, matcher=None):			def walksubtrees(self, matcher=None):
	"""Returns an iterator of the subtrees of this manifest, including this			"""Returns an iterator of the subtrees of this manifest, including this
	manifest itself.			manifest itself.