Page MenuHomePhabricator

pager: migrate to modern pager API
ClosedPublic

Authored by quark on Aug 17 2017, 3:52 PM.

Details

Reviewers
ryanmce
sid0
Group Reviewers
Restricted Project
Commits
rFBHGX652f86010cee: pager: migrate to modern pager API
Summary

The modern pager API is to use ui.pager() explicitly just before the time
a command needs a pager. It's now hard-coded in individual commands, and
opt-in by default. Users wanting to disable pagers for certain commands need
to disable them explicitly. Ideally we don't need the pager extensions or
the pager.attend setting.

This patch migrates show, smartlog, fastannotate, and grep to use
the modern API.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Aug 17 2017, 3:52 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2017, 3:52 PM
quark edited the summary of this revision. (Show Details)Aug 17 2017, 4:13 PM
quark updated this revision to Diff 1048.
sid0 accepted this revision.Aug 17 2017, 4:22 PM
This revision is now accepted and ready to land.Aug 17 2017, 4:22 PM
This revision was automatically updated to reflect the committed changes.