This is an archive of the discontinued Mercurial Phabricator instance.

rename: return error status if any rename/copy failed
ClosedPublic

Authored by martinvonz on Aug 29 2018, 1:47 PM.

Details

Summary

Ever since 447ea621e50e (copy: propagate errors properly, 2007-12-06),
we have returned an error status if the source file did not
exist. That commit did not return error status for any other errors,
and it's unclear if that was on purpose or not. It seems to me like we
should return an error in the other cases to, so that's what this
patch does.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Aug 29 2018, 1:47 PM
pulkit accepted this revision.Aug 29 2018, 3:29 PM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
tests/test-rename.t
343

Not sure how I feel about this one. There are few operations which succeed and few which does not.

This revision was automatically updated to reflect the committed changes.