( )⚙ D443 fastlog: use ui.log() instead of ui.warn()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D443

fastlog: use ui.log() instead of ui.warn()
ClosedPublic

Authored by stash on Aug 18 2017, 12:43 PM.
Tags
None
Subscribers
None

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGXecc4c4abe485: fastlog: use ui.log() instead of ui.warn()
Summary

ui.warn() just prints to the stderr. It has two disadvantages:

  1. Distracts a user
  2. Doesn't notify us about the problem.

Let's use ui.log() that will send result to our logging system

Test Plan

Run unit-tests

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Branch
default
Lint
Lint OK
Unit
Unit Tests OK

Event Timeline

stash created this revision.Aug 18 2017, 12:43 PM
quark accepted this revision.Aug 18 2017, 2:32 PM
This revision is now accepted and ready to land.Aug 18 2017, 2:32 PM
Closed by commit rFBHGXecc4c4abe485: fastlog: use ui.log() instead of ui.warn() (authored by stash). · Explain WhyAug 22 2017, 10:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/fastlog.py (2 lines)

Diff 1072

hgext3rd/fastlog.py

try: try:
producer, success, msg = queue.get(True, 3600) producer, success, msg = queue.get(True, 3600)
except util.empty: except util.empty:
raise error.Abort("Timeout reading log data") raise error.Abort("Timeout reading log data")
if not success: if not success:
if producer == LOCAL: if producer == LOCAL:
raise error.Abort(msg) raise error.Abort(msg)
elif msg: elif msg:
repo.ui.warn(msg + '\n') repo.ui.log("hgfastlog", msg)
continue continue
if msg is None: if msg is None:
# Empty message means no more results # Empty message means no more results
return return
rev = msg rev = msg
if debug: if debug: