This is an archive of the discontinued Mercurial Phabricator instance.

drawdag: correctly pass repo to super constructor
ClosedPublic

Authored by martinvonz on Sep 4 2018, 1:36 PM.

Reviewers

quark
pulkit

Group Reviewers

hg-reviewers

Commits

Summary

This was caught by someone who was looking for the

super(cls, self).__init__(self, ...)

pattern in all code in our Google-internal repo.

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

LGTM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			tests/drawdag.py (3 lines)


	class simplecommitctx(context.committablectx):			class simplecommitctx(context.committablectx):
	def __init__(self, repo, name, parentctxs, added):			def __init__(self, repo, name, parentctxs, added):
	opts = {			opts = {
	'changes': scmutil.status([], list(added), [], [], [], [], []),			'changes': scmutil.status([], list(added), [], [], [], [], []),
	'date': b'0 0',			'date': b'0 0',
	'extra': {b'branch': b'default'},			'extra': {b'branch': b'default'},
	}			}
	super(simplecommitctx, self).__init__(self, name, **opts)			super(simplecommitctx, self).__init__(repo, name, **opts)
	self._repo = repo
	self._added = added			self._added = added
	self._parents = parentctxs			self._parents = parentctxs
	while len(self._parents) < 2:			while len(self._parents) < 2:
	self._parents.append(repo[node.nullid])			self._parents.append(repo[node.nullid])

	def filectx(self, key):			def filectx(self, key):
	return simplefilectx(key, self._added[key])			return simplefilectx(key, self._added[key])