( )⚙ D4537 localrepo: add requirement when narrow files creation option present

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4537

localrepo: add requirement when narrow files creation option present
ClosedPublic

Authored by indygreg on Sep 11 2018, 8:27 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG261f1e8dc300: localrepo: add requirement when narrow files creation option present
Summary

The previous commit taught hg.clone() to define a creation option
when file include or exclude patterns are passed.

This commit teaches the new repo creation code to convert that creation
option into a repository requirement.

While not yet used by the narrow extension, the eventual side-effect
of this change is that newly-created repositories will have the narrow
requirement from their creation onset. Currently, the requirement is
added to the repo at exchange.pull() time via a wrapped function in
the narrow extension.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (7 lines)

Diff 10914

mercurial/localrepo.py

requirements.remove('revlogv1') requirements.remove('revlogv1')
# generaldelta is implied by revlogv2. # generaldelta is implied by revlogv2.
requirements.discard('generaldelta') requirements.discard('generaldelta')
requirements.add(REVLOGV2_REQUIREMENT) requirements.add(REVLOGV2_REQUIREMENT)
# experimental config: format.internal-phase # experimental config: format.internal-phase
if ui.configbool('format', 'internal-phase'): if ui.configbool('format', 'internal-phase'):
requirements.add('internal-phase') requirements.add('internal-phase')
if createopts.get('narrowfiles'):
requirements.add(repository.NARROW_REQUIREMENT)
return requirements return requirements
def filterknowncreateopts(ui, createopts): def filterknowncreateopts(ui, createopts):
"""Filters a dict of repo creation options against options that are known. """Filters a dict of repo creation options against options that are known.
Receives a dict of repo creation options and returns a dict of those Receives a dict of repo creation options and returns a dict of those
options that we don't know how to handle. options that we don't know how to handle.
This function is called as part of repository creation. If the This function is called as part of repository creation. If the
returned dict contains any items, repository creation will not returned dict contains any items, repository creation will not
be allowed, as it means there was a request to create a repository be allowed, as it means there was a request to create a repository
with options not recognized by loaded code. with options not recognized by loaded code.
Extensions can wrap this function to filter out creation options Extensions can wrap this function to filter out creation options
they know how to handle. they know how to handle.
""" """
return dict(createopts) known = {'narrowfiles'}
return {k: v for k, v in createopts.items() if k not in known}
def createrepository(ui, wdirvfs, createopts=None): def createrepository(ui, wdirvfs, createopts=None):
"""Create a new repository in a vfs. """Create a new repository in a vfs.
``wdirvfs`` is a vfs instance pointing at the working directory. ``wdirvfs`` is a vfs instance pointing at the working directory.
``requirements`` is a set of requirements for the new repository. ``requirements`` is a set of requirements for the new repository.
""" """
createopts = createopts or {} createopts = createopts or {}