This is an archive of the discontinued Mercurial Phabricator instance.

narrow: drop support for remote expansion (BC)
ClosedPublic

Authored by indygreg on Sep 11 2018, 6:59 PM.

Details

Summary

Previous patches to validate narrow patterns accidentically dropped
support for the include: syntax that allows patterns to be expanded
from a remote.

This feature was never implemented in core and is only implemented on
Google's custom server. Per @martinvonz's review comment in D4522, it
is OK to drop this feature since it isn't used.

The concept of this feature does seem useful. I anticipate it making
a comeback some day in some shape or form. But for now, let's jettison
the dead code.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 11 2018, 6:59 PM
pulkit accepted this revision.Sep 12 2018, 7:49 AM
This revision was automatically updated to reflect the committed changes.