This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4545

error: ensure ProgrammingError message is always a str
ClosedPublic

Authored by durin42 on Sep 12 2018, 11:40 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG921aeb9ac508: error: ensure ProgrammingError message is always a str
Summary

Since this error is internal-only and a runtime error, let's give it a
treatment that makes it behave identically when repr()d on both Python
2 and Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 12 2018, 11:40 AM
pulkit accepted this revision.Sep 12 2018, 11:44 AM
durin42 updated this revision to Diff 10958.Sep 12 2018, 12:24 PM
Closed by commit rHG921aeb9ac508: error: ensure ProgrammingError message is always a str (authored by durin42). · Explain WhySep 12 2018, 12:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/error.py (10 lines)

Diff 10959

mercurial/error.py

__bytes__ = _tobytes __bytes__ = _tobytes
class PushRaced(RuntimeError): class PushRaced(RuntimeError):
"""An exception raised during unbundling that indicate a push race""" """An exception raised during unbundling that indicate a push race"""
__bytes__ = _tobytes __bytes__ = _tobytes
class ProgrammingError(Hint, RuntimeError): class ProgrammingError(Hint, RuntimeError):
"""Raised if a mercurial (core or extension) developer made a mistake""" """Raised if a mercurial (core or extension) developer made a mistake"""
def __init__(self, msg, *args, **kwargs):
if not isinstance(msg, str):
# This means we're on Python 3, because we got a
# bytes. Turn the message back into a string since this is
# an internal-only error that won't be printed except in a
# stack traces.
msg = msg.decode('utf8')
super(ProgrammingError, self).__init__(msg, *args, **kwargs)
__bytes__ = _tobytes __bytes__ = _tobytes
class WdirUnsupported(Exception): class WdirUnsupported(Exception):
"""An exception which is raised when 'wdir()' is not supported""" """An exception which is raised when 'wdir()' is not supported"""
__bytes__ = _tobytes __bytes__ = _tobytes
# bundle2 related errors # bundle2 related errors
class BundleValueError(ValueError): class BundleValueError(ValueError):