This is an archive of the discontinued Mercurial Phabricator instance.

revset: micro optimize _flipand by using anyorder for inner set
AbandonedPublic

Authored by quark on Aug 20 2017, 6:13 PM.

Reviewers

None

Group Reviewers

hg-reviewers

Summary

Now the ordering issues are resolved so we can use anyorder for x in
_flipand(x, y).

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

This whole series looks great to me, but I'll let Yuya queue it since he knows this area better.

			Path	Packages
M			mercurial/revset.py (5 lines)
M			tests/test-revset.t (2 lines)

Status	Author	Revision
Abandoned	quark	D460 revset: micro optimize _flipand by using anyorder for inner set
Abandoned	quark	D459 revset: correct ordering issues caused by `return x - y`
Abandoned	quark	D458 revset: correct ordering issues caused by `return subset.filter(...)`
Abandoned	quark	D457 revset: infer takeorder from function arguments
Abandoned	quark	D456 revset: provide a way to check ordering support
Abandoned	quark	D453 revset: make subrepo optional in revset predicate functions
Abandoned	quark	D452 revset: add an order-aware intersect helper function


	return s			return s

	@predicate('_flipand(x, y)', safe=True, takeorder=True)			@predicate('_flipand(x, y)', safe=True, takeorder=True)
	def _flipand(repo, subset, args, order):			def _flipand(repo, subset, args, order):
	"""Equivalent to ``y and x``, but faster when x is small"""			"""Equivalent to ``y and x``, but faster when x is small"""
	x, y = getargs(args, 2, 2, _("missing argument"))			x, y = getargs(args, 2, 2, _("missing argument"))
	if order == defineorder:			if order == defineorder:
	# NOTE: In theory this could be "anyorder". But many revsets (ex.			xorder = anyorder
	# "contains") do not handle "defineorder" correctly. This has to be
	# followorder for now to hide those issues.
	xorder = followorder
	else:			else:
	xorder = order			xorder = order
	return getset(repo, getset(repo, subset, x, xorder), y, order)			return getset(repo, getset(repo, subset, x, xorder), y, order)

	@predicate('follow([pattern[, startrev]])', safe=True)			@predicate('follow([pattern[, startrev]])', safe=True)
	def follow(repo, x):			def follow(repo, x):
	"""			"""
	An alias for ``::.`` (ancestors of the working directory's first parent).			An alias for ``::.`` (ancestors of the working directory's first parent).

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1121			Aug 20 2017, 6:13 PM	★	★