This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4602

phabricator: move extension from contrib to hgext
ClosedPublic

Authored by durin42 on Sep 15 2018, 1:23 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd2c81e83de2a: phabricator: move extension from contrib to hgext
Summary

It's well-enough tested now and widely enough used I think we should
ship it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 15 2018, 1:23 AM
durin42 updated this revision to Diff 11083.Sep 15 2018, 1:49 AM
yuja added a subscriber: yuja.Sep 15 2018, 3:23 AM

Added workaround for test-check-help. as follows:

diff --git a/tests/test-check-help.t b/tests/test-check-help.t
--- a/tests/test-check-help.t
+++ b/tests/test-check-help.t
@@ -26,4 +26,4 @@ Check if ":hg:`help TOPIC`" is valid:
   $ testrepohg files 'glob:{hgdemandimport,hgext,mercurial}/**/*.py' \
   > | sed 's|\\|/|g' \
   > | xargs $PYTHON "$TESTTMP/scanhelptopics.py" \
-  > | xargs -n1 hg help > /dev/null
+  > | xargs -n1 hg help --config extensions.phabricator= > /dev/null

This doesn't look nice, but should be okay for now.

Closed by commit rHGd2c81e83de2a: phabricator: move extension from contrib to hgext (authored by durin42). · Explain WhySep 15 2018, 3:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11091

contrib/phabricator.py

  • This file was moved to hgext/phabricator.py.

hgext/phabricator.py

  • This file was moved from contrib/phabricator.py.

tests/test-check-help.t

$ cd "$TESTDIR"/.. $ cd "$TESTDIR"/..
Check if ":hg:`help TOPIC`" is valid: Check if ":hg:`help TOPIC`" is valid:
(use "xargs -n1 -t" to see which help commands are executed) (use "xargs -n1 -t" to see which help commands are executed)
$ testrepohg files 'glob:{hgdemandimport,hgext,mercurial}/**/*.py' \ $ testrepohg files 'glob:{hgdemandimport,hgext,mercurial}/**/*.py' \
> | sed 's|\\|/|g' \ > | sed 's|\\|/|g' \
> | xargs $PYTHON "$TESTTMP/scanhelptopics.py" \ > | xargs $PYTHON "$TESTTMP/scanhelptopics.py" \
> | xargs -n1 hg help > /dev/null > | xargs -n1 hg help --config extensions.phabricator= > /dev/null

tests/test-phabricator.t

#require vcr #require vcr
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF
> [extensions] > [extensions]
> phabricator = $TESTDIR/../contrib/phabricator.py > phabricator =
> EOF > EOF
$ hg init repo $ hg init repo
$ cd repo $ cd repo
$ cat >> .hg/hgrc <<EOF $ cat >> .hg/hgrc <<EOF
> [phabricator] > [phabricator]
> url = https://phab.mercurial-scm.org/ > url = https://phab.mercurial-scm.org/
> callsign = HG > callsign = HG
> >