This is an archive of the discontinued Mercurial Phabricator instance.

zsh_completion: add -b/--branch and -B/--bookmark(s) flags properly
ClosedPublic

Authored by av6 on Sep 17 2018, 2:08 AM.

Details

Summary

_hg_branch_bmark_opts used to add these two flags, but had the same
descriptions for the flags regardless of what command took them and didn't
allow specifying flags more than once (no '*' at the start). Even more
importantly, it assumed that -B was always expecting an argument (i.e.
--bookmark=foo), but in case of incoming and outgoing it's not so (--bookmarks
is self-sufficient).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

av6 created this revision.Sep 17 2018, 2:08 AM
spectral accepted this revision.Sep 17 2018, 5:46 PM
pulkit accepted this revision.Sep 18 2018, 11:52 AM
This revision was automatically updated to reflect the committed changes.