This is an archive of the discontinued Mercurial Phabricator instance.

wireprotov2: advertise recognized path filter prefixes
ClosedPublic

Authored by indygreg on Sep 17 2018, 5:23 PM.

Details

Summary

While the wire protocol doesn't yet support it, we'll eventually
have commands that accept narrow patterns to specify the set of
files relevant to a command.

For security and performance reasons, only specific filter types
are allowed.

This commit teaches the server to advertise the set of allowed
filter types. By doing so, clients can e.g. validate user-specified
patterns against the server's abilities without having to send
a command to retrieve data.

Having the data in the capabilities data structure will also serve
as a check against unwanted BC.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 17 2018, 5:23 PM
durin42 accepted this revision.Sep 18 2018, 5:33 PM
This revision is now accepted and ready to land.Sep 18 2018, 5:33 PM
indygreg updated this revision to Diff 11244.Sep 20 2018, 5:14 PM
This revision was automatically updated to reflect the committed changes.