This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4623

transaction: make undoname a private attribute
ClosedPublic

Authored by indygreg on Sep 17 2018, 7:36 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGda9ce63bfa9b: transaction: make undoname a private attribute
Summary

This attribute tracks the file pattern to use for undo files.
It is an implementation detail of the current transaction semantics
and doesn't need to be part of the future transaction interface. So
mark it as private.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 17 2018, 7:36 PM
Closed by commit rHGda9ce63bfa9b: transaction: make undoname a private attribute (authored by indygreg). · Explain WhySep 18 2018, 5:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/transaction.py (9 lines)

Diff 11149

mercurial/transaction.py

# a map to access file in various {location -> vfs} # a map to access file in various {location -> vfs}
vfsmap = vfsmap.copy() vfsmap = vfsmap.copy()
vfsmap[''] = opener # set default value vfsmap[''] = opener # set default value
self._vfsmap = vfsmap self._vfsmap = vfsmap
self.after = after self.after = after
self.entries = [] self.entries = []
self.map = {} self.map = {}
self.journal = journalname self.journal = journalname
self.undoname = undoname self._undoname = undoname
self._queue = [] self._queue = []
# A callback to validate transaction content before closing it. # A callback to validate transaction content before closing it.
# should raise exception is anything is wrong. # should raise exception is anything is wrong.
# target user is repository hooks. # target user is repository hooks.
if validator is None: if validator is None:
validator = lambda tr: None validator = lambda tr: None
self.validator = validator self.validator = validator
# A callback to do something just after releasing transaction. # A callback to do something just after releasing transaction.
def abort(self): def abort(self):
'''abort the transaction (generally called on error, or when the '''abort the transaction (generally called on error, or when the
transaction is not explicitly committed before going out of transaction is not explicitly committed before going out of
scope)''' scope)'''
self._abort() self._abort()
def _writeundo(self): def _writeundo(self):
"""write transaction data for possible future undo call""" """write transaction data for possible future undo call"""
if self.undoname is None: if self._undoname is None:
return return
undobackupfile = self.opener.open("%s.backupfiles" % self.undoname, 'w') undobackupfile = self.opener.open("%s.backupfiles" % self._undoname,
'w')
undobackupfile.write('%d\n' % version) undobackupfile.write('%d\n' % version)
for l, f, b, c in self._backupentries: for l, f, b, c in self._backupentries:
if not f: # temporary file if not f: # temporary file
continue continue
if not b: if not b:
u = '' u = ''
else: else:
if l not in self._vfsmap and c: if l not in self._vfsmap and c:
self.report("couldn't remove %s: unknown cache location" self.report("couldn't remove %s: unknown cache location"
"%s\n" % (b, l)) "%s\n" % (b, l))
continue continue
vfs = self._vfsmap[l] vfs = self._vfsmap[l]
base, name = vfs.split(b) base, name = vfs.split(b)
assert name.startswith(self.journal), name assert name.startswith(self.journal), name
uname = name.replace(self.journal, self.undoname, 1) uname = name.replace(self.journal, self._undoname, 1)
u = vfs.reljoin(base, uname) u = vfs.reljoin(base, uname)
util.copyfile(vfs.join(b), vfs.join(u), hardlink=True) util.copyfile(vfs.join(b), vfs.join(u), hardlink=True)
undobackupfile.write("%s\0%s\0%s\0%d\n" % (l, f, u, c)) undobackupfile.write("%s\0%s\0%s\0%d\n" % (l, f, u, c))
undobackupfile.close() undobackupfile.close()
def _abort(self): def _abort(self):
self._count = 0 self._count = 0