This is an archive of the discontinued Mercurial Phabricator instance.

Differential D465

interactivui: get rid of flashing
ClosedPublic

Authored by felixmerk on Aug 21 2017, 4:07 PM.
Tags
None
Subscribers
None

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX5a0f3c3c83b0: interactivui: get rid of flashing
Summary

Prevent flashing in 'hg undo -i' for smoother ux. Tested by running hg undo -i
and not seeing flashes when hitting left or right.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

felixmerk created this revision.Aug 21 2017, 4:07 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2017, 4:07 PM
quark accepted this revision.Aug 21 2017, 6:41 PM
This revision is now accepted and ready to land.Aug 21 2017, 6:41 PM
Closed by commit rFBHGX5a0f3c3c83b0: interactivui: get rid of flashing (authored by felixmerk). · Explain WhyAug 21 2017, 8:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext3rd/interactiveui.py (19 lines)

Diff 1131

hgext3rd/interactiveui.py

import tty import tty
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial import ( from mercurial import (
error, error,
) )
def upline(n=1):
w = sys.stdout
# ANSI
# ESC[#A : up # lines
w.write('\033[%dA' % n)
def clearline(n=1): def clearline(n=1):
w = sys.stdout w = sys.stdout
# ANSI # ANSI
# ESC[#A : up # lines # ESC[#A : up # lines
# ESC[K : clear to end of line # ESC[K : clear to end of line
for i in range(n): for i in range(n):
w.write('\033[1A\033[K') w.write('\033[1A\033[K')
w.flush()
# From: # From:
# https://github.com/pallets/click/blob/master/click/_termui_impl.py#L534 # https://github.com/pallets/click/blob/master/click/_termui_impl.py#L534
# As per licence: # As per licence:
# Copyright (c) 2014 by Armin Ronacher. # Copyright (c) 2014 by Armin Ronacher.
# #
# Click uses parts of optparse written by Gregory P. Ward and maintained by # Click uses parts of optparse written by Gregory P. Ward and maintained by
# the Python software foundation. This is limited to code in the parser.py # the Python software foundation. This is limited to code in the parser.py
# \r = return # \r = return
viewobj.enter() viewobj.enter()
done = True done = True
break break
if repr(output) == '\'\\x1b[C\'': if repr(output) == '\'\\x1b[C\'':
viewobj.rightarrow() viewobj.rightarrow()
if repr(output) == '\'\\x1b[D\'': if repr(output) == '\'\\x1b[D\'':
viewobj.leftarrow() viewobj.leftarrow()
clearline(s.count("\n")) linecount = s.count('\n')
s = viewobj.render() s = viewobj.render()
sys.stdout.write(s) newlinecount = s.count('\n')
if newlinecount < linecount:
clearline(linecount - newlinecount)
upline(newlinecount)
else:
upline(linecount)
slist = s.splitlines(True)
sys.stdout.write(''.join('\033[K' + line for line in slist))
sys.stdout.flush()