This is an archive of the discontinued Mercurial Phabricator instance.

filelog: drop index attribute (API)
ClosedPublic

Authored by indygreg on Sep 24 2018, 1:15 PM.

Details

Summary

The previous commit removed the last consumer of the "index" attribute
on the file storage interface. The index is an extremely low-level
data structure that is revlog specific and isn't appropriate to
expose as part of a generic storage API. There may be a market for
an efficient data structure to obtain metadata on every revision for
a file. But if there is, it should be designed using e.g. named
attributes for lookup instead of a list-like of 8-tuples.

Let's drop the attribute from filelog and remove the attribute from
the file storage interface.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 24 2018, 1:15 PM
This revision was automatically updated to reflect the committed changes.