This is an archive of the discontinued Mercurial Phabricator instance.

lfs: add repository feature denoting the use of LFS
ClosedPublic

Authored by indygreg on Sep 24 2018, 12:12 PM.

Details

Summary

Whether LFS is enabled seems like a useful feature to expose. This
will also facilitate some future work around LFS feature compatibility.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Sep 24 2018, 12:12 PM
mharbison72 accepted this revision.Sep 25 2018, 12:04 AM
mharbison72 added a subscriber: mharbison72.

Is it worth doing this with largefiles too? (I can follow up when this settles out- I just wasn't sure what particular future work you had in mind, since the autoload on requires works without it.)

Is it worth doing this with largefiles too? (I can follow up when this settles out- I just wasn't sure what particular future work you had in mind, since the autoload on requires works without it.)

Probably.

I wasn't planning on touching largefiles too much because to this point, it hasn't gotten in the way of my storage refactorings :)

Is it worth doing this with largefiles too? (I can follow up when this settles out- I just wasn't sure what particular future work you had in mind, since the autoload on requires works without it.)

Probably.
I wasn't planning on touching largefiles too much because to this point, it hasn't gotten in the way of my storage refactorings :)

LOL. Fair enough. I'm not worried about trying to make it as nice as LFS, I'm just testing my understanding of the planned changes.

This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Sep 28 2018, 9:56 PM

+ wrapfunction(localrepo, 'makefilestorage', wrapper.localrepomakefilestorage)

As I pointed out before, makefilestorage can't be wrapped in this way
because it's captured as REPO_INTERFACES[1][1] earlier. The easiest
workaround I can think of is to wrap the reference in REPO_INTERFACES
with lambda, so the makefilestorage is looked up by name every time.