This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4760

remotefilelog: support emitrevisions API recently added to hg
ClosedPublic

Authored by durin42 on Sep 26 2018, 4:37 PM.
Tags
None
Subscribers
indygreg

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rFBHGXedfcee9f0649: remotefilelog: support emitrevisions API recently added to hg
Summary

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Sep 26 2018, 4:37 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2018, 4:37 PM
indygreg added a subscriber: indygreg.Sep 26 2018, 4:52 PM

This code is overly simple and will fail when e.g. serving data to shallow clients not using RFL. But I don't think we care.

durin42 added a comment.Sep 26 2018, 4:53 PM
In D4760#72139, @indygreg wrote:

This code is overly simple and will fail when e.g. serving data to shallow clients not using RFL. But I don't think we care.

That's my feeling too. We'll clean it up when we start harmonizing this with core.

Closed by commit rFBHGXedfcee9f0649: remotefilelog: support emitrevisions API recently added to hg (authored by durin42). · Explain WhySep 28 2018, 12:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11459

remotefilelog/remotefilelog.py

def linknode(self, node): def linknode(self, node):
ancestormap = self.repo.metadatastore.getancestors(self.filename, node) ancestormap = self.repo.metadatastore.getancestors(self.filename, node)
p1, p2, linknode, copyfrom = ancestormap[node] p1, p2, linknode, copyfrom = ancestormap[node]
return linknode return linknode
def linkrev(self, node): def linkrev(self, node):
return self.repo.unfiltered().changelog.rev(self.linknode(node)) return self.repo.unfiltered().changelog.rev(self.linknode(node))
def emitrevisions(self, nodes, nodesorder=None, revisiondata=False,
assumehaveparentrevisions=False, deltaprevious=False):
# we don't use any of these parameters here
del nodesorder, revisiondata, assumehaveparentrevisions, deltaprevious
prevnode = None
for node in nodes:
p1, p2 = self.parents(node)
if prevnode is None:
basenode = prevnode = p1
revision = None
delta = self.revdiff(basenode, node)
yield revlog.revlogrevisiondelta(
node=node,
p1node=p1,
p2node=p2,
linknode=self.linknode(node),
basenode=basenode,
flags=self.flags(node),
baserevisionsize=None,
revision=revision,
delta=delta,
)
def emitrevisiondeltas(self, requests): def emitrevisiondeltas(self, requests):
prevnode = None prevnode = None
for request in requests: for request in requests:
node = request.node node = request.node
p1, p2 = self.parents(node) p1, p2 = self.parents(node)
if prevnode is None: if prevnode is None:
prevnode = p1 prevnode = p1
if request.basenode is not None: if request.basenode is not None: