This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4849

store: introduce a function to get tracked path from a fncache entry
AbandonedPublic

Authored by pulkit on Oct 3 2018, 11:02 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Summary

This patch introduces a function to get the trakced path from a fncache entry.
This will be used to filter out files to streamclone using a narrowmatcher.

The function decodes the entries, and then returns the part after omitting the
ending .d, .i and starting meta/ and data/.

I am not sure if this is correct.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 3 2018, 11:02 AM
pulkit added a subscriber: yuja.Oct 12 2018, 5:30 PM

@yuja You might want to look at this. This is what I was referencing to when I mentioned about getting the filename back from a fncache entry. We need this for narrow-stream clones.

indygreg requested changes to this revision.Oct 13 2018, 3:54 AM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
mercurial/store.py
36–37

The fncache file doesn't track filenames beginning with dh/.

The fncache tracks the real full paths and then store filename encoding happens later.

This revision now requires changes to proceed.Oct 13 2018, 3:54 AM
indygreg added a comment.Oct 13 2018, 3:56 AM

... And the fncache tracks the paths that are fed into the vfs. I'm not sure why you'd want to strip the "data/" and "meta/" prefixes in this function.

If you are operating on a filelog, you "know" that its path should be prefixed with "data/".

pulkit abandoned this revision.Nov 13 2018, 9:04 AM

This was an incorrect implementation. A better implementation has been pushed as part of D5139.

Revision Contents
Changeset List

PathPackages
Mmercurial/store.py (15 lines)

Diff 11601

mercurial/store.py

policy, policy,
pycompat, pycompat,
util, util,
vfs as vfsmod, vfs as vfsmod,
) )
parsers = policy.importmod(r'parsers') parsers = policy.importmod(r'parsers')
def _gettrackedpath(path):
"""parses a fncahe entry and returns the path which that
entry is tracking.
If None is returned, it means it does not track any path.
"""
path = decodefilename(path)
if path.startswith('data/'):
return path[5:-2]
elif path.startswith('dh/'):
return path[3:-2]
indygregUnsubmitted
Not Done

The fncache file doesn't track filenames beginning with dh/.

The fncache tracks the real full paths and then store filename encoding happens later.

indygreg: The fncache file doesn't track filenames beginning with `dh/`. The fncache tracks the real…
elif path.startswith('meta/'):
return path[5:-2]
return None
# This avoids a collision between a file named foo and a dir named # This avoids a collision between a file named foo and a dir named
# foo.i or foo.d # foo.i or foo.d
def _encodedir(path): def _encodedir(path):
''' '''
>>> _encodedir(b'data/foo.i') >>> _encodedir(b'data/foo.i')
'data/foo.i' 'data/foo.i'
>>> _encodedir(b'data/foo.i/bla.i') >>> _encodedir(b'data/foo.i/bla.i')
'data/foo.i.hg/bla.i' 'data/foo.i.hg/bla.i'