This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4930

context: fix typo in introrev()
AbandonedPublic

Authored by martinvonz on Oct 9 2018, 4:20 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

I didn't think about it while queuing this code, but I'm pretty sure
it's supposed to be "has stop rev", not "has top rev".

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Oct 9 2018, 4:20 PM
yuja added a subscriber: yuja.Oct 9 2018, 6:13 PM
I didn't think about it while queuing this code, but I'm pretty sure
it's supposed to be "has stop rev", not "has top rev".

I think "top rev" is correct since we'll walk down from the changeset
revision.

martinvonz added a comment.Oct 9 2018, 6:16 PM
In D4930#74270, @yuja wrote:
I didn't think about it while queuing this code, but I'm pretty sure
it's supposed to be "has stop rev", not "has top rev".

I think "top rev" is correct since we'll walk down from the changeset
revision.

Hmm, sounds like what we'd call "start" elsewhere then. Maybe "hasstartrev". Since it's unclear, I'll just drop this patch.

martinvonz abandoned this revision.Oct 9 2018, 6:16 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (4 lines)

Diff 11772

mercurial/context.py

This method is different from linkrev because it take into account the This method is different from linkrev because it take into account the
changeset the filectx was created from. It ensures the returned changeset the filectx was created from. It ensures the returned
revision is one of its ancestors. This prevents bugs from revision is one of its ancestors. This prevents bugs from
'linkrev-shadowing' when a file revision is used by multiple 'linkrev-shadowing' when a file revision is used by multiple
changesets. changesets.
""" """
attrs = vars(self) attrs = vars(self)
hastoprev = (r'_changeid' in attrs or r'_changectx' in attrs) hasstoprev = (r'_changeid' in attrs or r'_changectx' in attrs)
if hastoprev: if hasstoprev:
return self._adjustlinkrev(self.rev(), inclusive=True) return self._adjustlinkrev(self.rev(), inclusive=True)
else: else:
return self.linkrev() return self.linkrev()
def introfilectx(self): def introfilectx(self):
"""Return filectx having identical contents, but pointing to the """Return filectx having identical contents, but pointing to the
changeset revision where this filectx was introduced""" changeset revision where this filectx was introduced"""
introrev = self.introrev() introrev = self.introrev()