This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4935

wireprotov2: raise ProgrammingError on unknown action
ClosedPublic

Authored by indygreg on Oct 11 2018, 2:20 AM.
Tags
None
Subscribers
durin42

Details

Reviewers
None
Commits
rHG17223d8e7d75: wireprotov2: raise ProgrammingError on unknown action
Summary

Suggested by @durin42 in review of D4923.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 11 2018, 2:20 AM
indygreg planned changes to this revision.Oct 11 2018, 3:10 AM

I should have ran tests before submitting this...

indygreg updated this revision to Diff 11796.Oct 11 2018, 3:12 AM
durin42 added inline comments.Oct 11 2018, 3:36 AM
mercurial/wireprotov2peer.py
340

I love the smell of vindication in the morning.

Closed by commit rHG17223d8e7d75: wireprotov2: raise ProgrammingError on unknown action (authored by indygreg). · Explain WhyOct 11 2018, 3:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotov2peer.py (5 lines)

Diff 11797

mercurial/wireprotov2peer.py

self._futures[frame.requestid].set_exception(e) self._futures[frame.requestid].set_exception(e)
del self._futures[frame.requestid] del self._futures[frame.requestid]
else: else:
raise e raise e
return return
elif action == 'noop': elif action == 'noop':
return return
elif action == 'responsedata':
durin42Unsubmitted
Not Done

I love the smell of vindication in the morning.

durin42: I love the smell of vindication in the morning.
# Handled below.
pass
else:
raise error.ProgrammingError('action not handled: %s' % action)
if frame.requestid not in self._requests: if frame.requestid not in self._requests:
raise error.ProgrammingError( raise error.ProgrammingError(
'received frame for unknown request; this is either a bug in ' 'received frame for unknown request; this is either a bug in '
'the clientreactor not screening for this or this instance was ' 'the clientreactor not screening for this or this instance was '
'never told about this request: %r' % frame) 'never told about this request: %r' % frame)
response = self._responses[frame.requestid] response = self._responses[frame.requestid]