This is an archive of the discontinued Mercurial Phabricator instance.

Differential D4923

wireprotov2: handle noop action
ClosedPublic

Authored by indygreg on Oct 8 2018, 8:29 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGcfeba1aafb9d: wireprotov2: handle noop action
Summary

This action can be returned from the client reactor. We should
handle it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 8 2018, 8:29 PM
durin42 added a subscriber: durin42.Oct 10 2018, 10:49 AM
durin42 added inline comments.
mercurial/wireprotov2peer.py
328

as a followup, maybe add an

else:

raise error.ProgrammingError(...)
Closed by commit rHGcfeba1aafb9d: wireprotov2: handle noop action (authored by indygreg). · Explain WhyOct 10 2018, 10:57 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotov2peer.py (2 lines)

Diff 11787

mercurial/wireprotov2peer.py

if frame.requestid in self._futures: if frame.requestid in self._futures:
self._futures[frame.requestid].set_exception(e) self._futures[frame.requestid].set_exception(e)
del self._futures[frame.requestid] del self._futures[frame.requestid]
else: else:
raise e raise e
return return
elif action == 'noop':
durin42Unsubmitted
Not Done

as a followup, maybe add an

else:

raise error.ProgrammingError(...)
durin42: as a followup, maybe add an else: raise error.ProgrammingError(...)
return
if frame.requestid not in self._requests: if frame.requestid not in self._requests:
raise error.ProgrammingError( raise error.ProgrammingError(
'received frame for unknown request; this is either a bug in ' 'received frame for unknown request; this is either a bug in '
'the clientreactor not screening for this or this instance was ' 'the clientreactor not screening for this or this instance was '
'never told about this request: %r' % frame) 'never told about this request: %r' % frame)
response = self._responses[frame.requestid] response = self._responses[frame.requestid]