This is an archive of the discontinued Mercurial Phabricator instance.

wireprotov2: send protocol settings frame from client
ClosedPublic

Authored by indygreg on Oct 8 2018, 8:29 PM.

Details

Summary

Now that we have client and server reactor support for protocol
settings and encoding frames, we can start to send them out over
the wire!

This commit teaches the client reactor to send out a protocol
settings frame when needed. The httpv2 peer has been taught to
gather a list of supported content encoders and to advertise them
through the client reactor.

Because the client is now sending new frame types by default, this
constitutes a compatibility break in the framing protocol. The
media type version has been bumped accordingly. This will ensure
existing clients won't attempt to send the new frames to old
servers not supporting this explicit media type. I'm not bothering
with the BC annotation because everything wireprotov2 is highly
experimental and nobody should be running a server yet.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 8 2018, 8:29 PM
This revision was automatically updated to reflect the committed changes.