This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5008

py3: convert sorting field to sysstr
ClosedPublic

Authored by indygreg on Oct 12 2018, 1:24 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGb8f6a99ad89b: py3: convert sorting field to sysstr
Summary

This is used as part of an attribute name check and needs to be native str.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 12 2018, 1:24 PM
pulkit accepted this revision.Oct 12 2018, 4:28 PM
Closed by commit rHGb8f6a99ad89b: py3: convert sorting field to sysstr (authored by indygreg). · Explain WhyOct 12 2018, 5:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/profiling.py (2 lines)

Diff 11945

mercurial/profiling.py

if format == 'kcachegrind': if format == 'kcachegrind':
from . import lsprofcalltree from . import lsprofcalltree
calltree = lsprofcalltree.KCacheGrind(p) calltree = lsprofcalltree.KCacheGrind(p)
calltree.output(fp) calltree.output(fp)
else: else:
# format == 'text' # format == 'text'
stats = lsprof.Stats(p.getstats()) stats = lsprof.Stats(p.getstats())
stats.sort(field) stats.sort(pycompat.sysstr(field))
stats.pprint(limit=limit, file=fp, climit=climit) stats.pprint(limit=limit, file=fp, climit=climit)
@contextlib.contextmanager @contextlib.contextmanager
def flameprofile(ui, fp): def flameprofile(ui, fp):
try: try:
from flamegraph import flamegraph from flamegraph import flamegraph
except ImportError: except ImportError:
raise error.Abort(_( raise error.Abort(_(