This is an archive of the discontinued Mercurial Phabricator instance.

py3: flush stdout
ClosedPublic

Authored by indygreg on Oct 12 2018, 1:25 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG9cc411952ab9: py3: flush stdout
Summary

This avoids buffering due to mixed print() and sys.stdout.write() by
profiling code.

And with this, test-profile.t passes on Python 3 \o/.

Honestly, I'd be shocked if there weren't more Python 3 encoding issues lingering
in the profiling code. That code isn't super high quality and doesn't seem to have
thorough test coverage.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Oct 12 2018, 1:25 PM
pulkit accepted this revision.Oct 12 2018, 4:39 PM
This revision was automatically updated to reflect the committed changes.