Page MenuHomePhabricator

ctreemanifest: move ManifestPtr to its own header file
ClosedPublic

Authored by simpkins on Aug 24 2017, 4:39 PM.

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX99ee66aae19b: ctreemanifest: move ManifestPtr to its own header file
Summary

Define the ManifestPtr class in its own header file, to eliminate some of the
nasty circular dependencies between manifest.h, manifest_entry.h, and
manifest_fetcher.h

This makes the include process for these files much simpler, and prevents
manifest.h and manifest_entry.h from both trying to include each other at
different locations in their files.

This corresponds to Facebook diff D5588672.

Test Plan

Confirmed "make local" succeeds and the unit tests pass.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

simpkins created this revision.Aug 24 2017, 4:39 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 24 2017, 4:39 PM
quark accepted this revision.Aug 24 2017, 5:42 PM
This revision is now accepted and ready to land.Aug 24 2017, 5:42 PM
This revision was automatically updated to reflect the committed changes.