This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5071

run-tests: run tests with as many processes as cores by default
ClosedPublic

Authored by indygreg on Oct 13 2018, 6:34 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGe7e70c033783: run-tests: run tests with as many processes as cores by default
Summary

This seems like a useful default behavior so tests run faster by default*

  • Except in special circumstances where the OS/filesystem doesn't scale well to many CPU cores (like APFS *cough* *cough*).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Oct 13 2018, 6:34 AM
pulkit accepted this revision.Oct 13 2018, 7:46 AM
Closed by commit rHGe7e70c033783: run-tests: run tests with as many processes as cores by default (authored by indygreg). · Explain WhyOct 13 2018, 8:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/run-tests.py (3 lines)
Mtests/test-run-tests.t (4 lines)

Diff 12054

tests/run-tests.py

from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
import argparse import argparse
import collections import collections
import difflib import difflib
import distutils.version as version import distutils.version as version
import errno import errno
import json import json
import multiprocessing
import os import os
import random import random
import re import re
import shutil import shutil
import signal import signal
import socket import socket
import subprocess import subprocess
import sys import sys
return p return p
PYTHON = _bytespath(sys.executable.replace('\\', '/')) PYTHON = _bytespath(sys.executable.replace('\\', '/'))
IMPL_PATH = b'PYTHONPATH' IMPL_PATH = b'PYTHONPATH'
if 'java' in sys.platform: if 'java' in sys.platform:
IMPL_PATH = b'JYTHONPATH' IMPL_PATH = b'JYTHONPATH'
defaults = { defaults = {
'jobs': ('HGTEST_JOBS', 1), 'jobs': ('HGTEST_JOBS', multiprocessing.cpu_count()),
'timeout': ('HGTEST_TIMEOUT', 180), 'timeout': ('HGTEST_TIMEOUT', 180),
'slowtimeout': ('HGTEST_SLOWTIMEOUT', 500), 'slowtimeout': ('HGTEST_SLOWTIMEOUT', 500),
'port': ('HGTEST_PORT', 20059), 'port': ('HGTEST_PORT', 20059),
'shell': ('HGTEST_SHELL', 'sh'), 'shell': ('HGTEST_SHELL', 'sh'),
} }
def canonpath(path): def canonpath(path):
return os.path.realpath(os.path.expanduser(path)) return os.path.realpath(os.path.expanduser(path))

tests/test-run-tests.t

running 0 tests using 0 parallel processes running 0 tests using 0 parallel processes
# Ran 0 tests, 0 skipped, 0 failed. # Ran 0 tests, 0 skipped, 0 failed.
Define a helper to avoid the install step Define a helper to avoid the install step
============= =============
$ rt() $ rt()
> { > {
> "$PYTHON" $TESTDIR/run-tests.py --with-hg=`which hg` "$@" > "$PYTHON" $TESTDIR/run-tests.py --with-hg=`which hg` -j1 "$@"
> } > }
error paths error paths
#if symlink #if symlink
$ ln -s `which true` hg $ ln -s `which true` hg
$ "$PYTHON" $TESTDIR/run-tests.py --with-hg=./hg $ "$PYTHON" $TESTDIR/run-tests.py --with-hg=./hg
warning: --with-hg should specify an hg script warning: --with-hg should specify an hg script
$ echo 172.16.18.1 $ echo 172.16.18.1
$LOCALIP (glob) $LOCALIP (glob)
$ echo dead:beef::1 $ echo dead:beef::1
$LOCALIP (glob) $LOCALIP (glob)
Add support for external test formatter Add support for external test formatter
======================================= =======================================
$ CUSTOM_TEST_RESULT=basic_test_result "$PYTHON" $TESTDIR/run-tests.py --with-hg=`which hg` "$@" test-success.t test-failure.t $ CUSTOM_TEST_RESULT=basic_test_result "$PYTHON" $TESTDIR/run-tests.py --with-hg=`which hg` -j1 "$@" test-success.t test-failure.t
running 2 tests using 1 parallel processes running 2 tests using 1 parallel processes
# Ran 2 tests, 0 skipped, 0 failed. # Ran 2 tests, 0 skipped, 0 failed.
ON_START! <__main__.TestSuite tests=[<__main__.TTest testMethod=test-failure.t>, <__main__.TTest testMethod=test-success.t>]> ON_START! <__main__.TestSuite tests=[<__main__.TTest testMethod=test-failure.t>, <__main__.TTest testMethod=test-success.t>]>
FAILURE! test-failure.t output changed FAILURE! test-failure.t output changed
SUCCESS! test-success.t SUCCESS! test-success.t
ON_END! ON_END!