This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5074

webcommands: use stringutil.pprint() to repr invalid archive types
ClosedPublic

Authored by durin42 on Oct 13 2018, 7:57 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGb24c23f7c1f9: webcommands: use stringutil.pprint() to repr invalid archive types
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Oct 13 2018, 7:57 AM
pulkit accepted this revision.Oct 13 2018, 8:11 AM
Closed by commit rHGb24c23f7c1f9: webcommands: use stringutil.pprint() to repr invalid archive types (authored by durin42). · Explain WhyOct 13 2018, 8:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/webcommands.py (2 lines)

Diff 12051

mercurial/hgweb/webcommands.py

No template is used for this handler. Raw, binary content is generated. No template is used for this handler. Raw, binary content is generated.
""" """
type_ = web.req.qsparams.get('type') type_ = web.req.qsparams.get('type')
allowed = web.configlist("web", "allow-archive") allowed = web.configlist("web", "allow-archive")
key = web.req.qsparams['node'] key = web.req.qsparams['node']
if type_ not in webutil.archivespecs: if type_ not in webutil.archivespecs:
msg = 'Unsupported archive type: %s' % type_ msg = 'Unsupported archive type: %s' % stringutil.pprint(type_)
raise ErrorResponse(HTTP_NOT_FOUND, msg) raise ErrorResponse(HTTP_NOT_FOUND, msg)
if not ((type_ in allowed or if not ((type_ in allowed or
web.configbool("web", "allow" + type_))): web.configbool("web", "allow" + type_))):
msg = 'Archive type not allowed: %s' % type_ msg = 'Archive type not allowed: %s' % type_
raise ErrorResponse(HTTP_FORBIDDEN, msg) raise ErrorResponse(HTTP_FORBIDDEN, msg)
reponame = re.sub(br"\W+", "-", os.path.basename(web.reponame)) reponame = re.sub(br"\W+", "-", os.path.basename(web.reponame))