This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5080

context: open files in bytes mode
ClosedPublic

Authored by durin42 on Oct 13 2018, 9:04 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG2f47703c5489: context: open files in bytes mode
Summary

I'm stunned this open() call has survived this long without the b in
the mode - it seems like it should have been a source of bugs somewhere...

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 13 2018, 9:04 AM
pulkit accepted this revision.Oct 13 2018, 9:17 AM
Closed by commit rHG2f47703c5489: context: open files in bytes mode (authored by durin42). · Explain WhyOct 13 2018, 10:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (2 lines)

Diff 12085

mercurial/context.py

with open(self._path, "rb") as f: with open(self._path, "rb") as f:
return f.read() return f.read()
def remove(self): def remove(self):
util.unlink(self._path) util.unlink(self._path)
def write(self, data, flags, **kwargs): def write(self, data, flags, **kwargs):
assert not flags assert not flags
with open(self._path, "w") as f: with open(self._path, "wb") as f:
f.write(data) f.write(data)