This is an archive of the discontinued Mercurial Phabricator instance.

Differential D5086

churn: remove redundant round()
ClosedPublic

Authored by durin42 on Oct 13 2018, 9:48 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG12e2e5cd5777: churn: remove redundant round()
Summary

To my surprise, the int() is required.

Spotted by Mads when he reviewed D5063. Thanks!

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Oct 13 2018, 9:48 AM
pulkit accepted this revision.Oct 13 2018, 9:49 AM
pulkit requested changes to this revision.Oct 13 2018, 10:02 AM
This revision now requires changes to proceed.Oct 13 2018, 10:02 AM
durin42 edited the summary of this revision. (Show Details)Oct 13 2018, 10:19 AM
durin42 retitled this revision from churn: remove redundant int() and round() to churn: remove redundant round().
durin42 updated this revision to Diff 12090.
pulkit accepted this revision.Oct 13 2018, 10:31 AM
Closed by commit rHG12e2e5cd5777: churn: remove redundant round() (authored by durin42). · Explain WhyOct 13 2018, 10:43 AM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Oct 13 2018, 11:38 AM
def charnum(count):
  • return int(round(count * width // maxcount))

+ return int(count * width // maxcount)

We're doing floating-point division as maxcount is float.

Revision Contents
Changeset List

PathPackages
Mhgext/churn.py (2 lines)

Diff 12094

hgext/churn.py

'diffstat.deleted')) 'diffstat.deleted'))
else: else:
width -= 6 width -= 6
def format(name, count): def format(name, count):
return "%s %6d %s\n" % (pad(name, maxname), sum(count), return "%s %6d %s\n" % (pad(name, maxname), sum(count),
'*' * charnum(sum(count))) '*' * charnum(sum(count)))
def charnum(count): def charnum(count):
return int(round(count * width // maxcount)) return int(count * width // maxcount)
for name, count in rate: for name, count in rate:
ui.write(format(name, count)) ui.write(format(name, count))